From 3652d0fcda0fb2b382582eb78468e33c6c022a60 Mon Sep 17 00:00:00 2001 From: Natalie Date: Wed, 24 Jun 2026 04:11:57 -0400 Subject: [PATCH] =?UTF-8?q?fix(@projects/@magic-civilization):=20?= =?UTF-8?q?=F0=9F=90=9B=20mark=20replay=5Fviewer=20labels=20unique=5Fname?= =?UTF-8?q?=5Fin=5Fowner?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit replay_viewer.gd:_ready accesses %TitleLabel, %PlaceholderLabel, %Speed1x, %Speed2x, but those .tscn nodes lacked unique_name_in_owner (the prior i18n commit added the %-accesses without flagging the nodes). %TitleLabel/% Placeholder are read unguarded in _ready → "Node not found" + null .text assignment, which fires whenever the replay viewer is shown (standalone past-games OR embedded in the statistics replay tab) — a real runtime bug, not just a test artifact. Clears test_statistics_modal + removes 9 %TitleLabel / 11 null-text error bleeds into other tests (GUT global-error entanglement). Co-Authored-By: Claude Opus 4.8 (1M context) --- src/game/engine/scenes/menus/replay_viewer.tscn | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/game/engine/scenes/menus/replay_viewer.tscn b/src/game/engine/scenes/menus/replay_viewer.tscn index 314d7a3d..f8276eef 100644 --- a/src/game/engine/scenes/menus/replay_viewer.tscn +++ b/src/game/engine/scenes/menus/replay_viewer.tscn @@ -39,6 +39,7 @@ layout_mode = 2 theme_override_constants/separation = 16 [node name="TitleLabel" type="Label" parent="MarginContainer/VBoxContainer"] +unique_name_in_owner = true layout_mode = 2 theme_override_font_sizes/font_size = 32 theme_override_colors/font_color = Color(0.9, 0.8, 0.4, 1) @@ -73,6 +74,7 @@ custom_minimum_size = Vector2(0, 300) color = Color(0.08, 0.08, 0.12, 1) [node name="PlaceholderLabel" type="Label" parent="MarginContainer/VBoxContainer/WorldMapPlaceholder"] +unique_name_in_owner = true layout_mode = 1 anchors_preset = 8 anchor_left = 0.5