From 774ffe962061c6a298e117eca61c0b07ea3fdc74 Mon Sep 17 00:00:00 2001 From: Natalie Date: Wed, 24 Jun 2026 05:11:05 -0400 Subject: [PATCH] =?UTF-8?q?test(@projects/@magic-civilization):=20?= =?UTF-8?q?=F0=9F=90=9B=20use=20real=20filter=20id=20"combat"=20not=20"mil?= =?UTF-8?q?itary"=20in=20chronicle=20test?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The chronicle panel's filter bucket id is "combat" (FILTER_BUCKETS["combat"], _filter_state["combat"]); the test toggled a non-existent "military" key, so nothing was filtered and combat entries stayed visible. Use "combat". Clears test_chronicle_coverage (721 passing / 6 failing). Co-Authored-By: Claude Opus 4.8 (1M context) --- src/game/engine/tests/unit/test_chronicle_coverage.gd | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/game/engine/tests/unit/test_chronicle_coverage.gd b/src/game/engine/tests/unit/test_chronicle_coverage.gd index 38527c21..285c6e54 100644 --- a/src/game/engine/tests/unit/test_chronicle_coverage.gd +++ b/src/game/engine/tests/unit/test_chronicle_coverage.gd @@ -133,8 +133,8 @@ func test_filter_hides_entries_by_category() -> void: # 3 entries total (all pass filter by default). assert_eq(panel.get_visible_entries().size(), panel.get_entry_count(), "default filter state shows everything") - # Turn off "military" (combat) — none emitted, count unchanged. - panel._filter_state["military"] = false + # Turn off "combat" — none emitted, count unchanged. + panel._filter_state["combat"] = false assert_eq(panel.get_visible_entries().size(), panel.get_entry_count(), "filtering combat when there's no combat leaves all entries visible") # Turn off "city" — founding + economy entries hidden. @@ -155,11 +155,11 @@ func test_combat_filter_hides_combat_only() -> void: panel._is_processing = false var initial_count: int = panel.get_entry_count() assert_gte(initial_count, 3, "expected at least 3 entries") - panel._filter_state["military"] = false + panel._filter_state["combat"] = false var visible: Array = panel.get_visible_entries() for entry: Dictionary in visible: assert_ne(entry.get("category"), "combat", - "no combat entries should pass when military filter is off") + "no combat entries should pass when combat filter is off") assert_lt(visible.size(), initial_count, "hiding military must reduce visible entry count")