applications/magicciv
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

feat(victory): ✨ Implement turn_limit setting logic in victory manager for turn-based game mechanics

Browse source 
Co-Authored-By: Lilith Autocommit <noreply@atlilith.com>
This commit is contained in:
autocommit 2026-04-16 18:49:06 -07:00
parent ef384a6b40
commit 1664234484
1 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/game/engine/src/modules/victory/victory_manager.gd
View file

@ -14,14 +14,29 @@ const UnitScript: GDScript = preload("res://engine/src/entities/unit.gd")
const CityScript: GDScript = preload("res://engine/src/entities/city.gd")
## Minimum turn before any victory check fires.
## Number of opening turns during which victory is suppressed. Early wins on
## degenerate maps (one player eliminated before the game has had time to
## develop) are not interesting and skew metrics — give every game at least
## this much runway before a winner can be declared.
const VICTORY_GRACE_TURNS: int = 10
## Turn limit after which score fallback fires. Mirrors TurnProcessor.max_turns.
const MAX_TURNS: int = 500
## Fallback turn limit if GameState.game_settings.turn_limit is missing.
## Real limit is read from game_settings["turn_limit"] at check time so the
## score fallback fires in sync with whichever limit the game actually runs
## against (batches set 300, real games may set 150 or 500).
const MAX_TURNS_FALLBACK: int = 500
var _game_over: bool = false
## Resolved max-turn limit for this run. Reads GameState.game_settings first
## so the score fallback fires at the same turn the game itself ends on, not
## a hardcoded constant that gets out of sync.
func _resolved_max_turns() -> int:
var settings: Dictionary = GameState.game_settings if GameState.game_settings != null else {}
return int(settings.get("turn_limit", MAX_TURNS_FALLBACK))
## Check all victory conditions. Emits EventBus.victory_achieved once.
func check_all(_game_map: RefCounted) -> void:
if _game_over:
@ -36,7 +51,7 @@ func check_all(_game_map: RefCounted) -> void:
return
# Score fallback: at max turns, award the highest-scoring player.
if GameState.turn_number >= MAX_TURNS:
if GameState.turn_number >= _resolved_max_turns():
var score_winner: int = _check_score_winner(_game_map)
if score_winner >= 0:
_game_over = true