applications/magicciv
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix(climate): 🐛 Prevent crashes in ecological event spawning by adding null/absent checks for resource configurations

Browse source 
Co-Authored-By: Lilith Autocommit <noreply@atlilith.com>
This commit is contained in:
autocommit 2026-06-06 23:56:40 -07:00
parent 0c734578e0
commit 5e3624eb29
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/game/engine/src/modules/climate/ecological_event_utils.gd
View file

@ -91,7 +91,13 @@ static func spawn_resource(tile: Variant, cfg: Dictionary) -> void:
spawn_resource_weighted(tile, table)
return
var resource_id: String = cfg.get("spawns_resource", "")
# `Dictionary.get(key, default)` only returns `default` when the key is
# ABSENT — a config with an explicit `"spawns_resource": null` returns
# `null` (Nil), which crashes a direct assignment to a typed `String`.
# Guard the null/absent case → no-spawn, matching `resource_terrain` below.
var resource_id: String = ""
if cfg.get("spawns_resource") != null:
resource_id = str(cfg["spawns_resource"])
if resource_id == "" or resource_id == "null":
return
var resource_terrain: Variant = cfg.get("resource_terrain", null)