applications/magicciv
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs: ✅ update test assertions for ransom events

Browse source 
Co-Authored-By: Lilith Autocommit <noreply@atlilith.com>
This commit is contained in:
Natalie 2026-05-09 02:10:49 -07:00
parent 023c6624d2
commit 7ccb3a4d62
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.project/objectives/p2-55e-richer-ransom-events.md
View file

@ -27,7 +27,7 @@ Chronicle currently distinguishes "expired-then-captured" from "fresh capture" b
- [x] `accept_ransom_offer` / `refuse_ransom_offer` push the corresponding event into `pending_capture_events.ransom_offers_accepted` / `_expired` so the next `step()` drains them onto TurnResult. ✓ `api-gdext/src/lib.rs:3791-3804` (accept) and `:3894-3905` (refuse). `PendingCaptureEvents.drain_into` updated at `mc-turn/src/game_state.rs:407-414` to drain both new vecs onto TurnResult.
- [x] api-gdext bridge surfaces both as `Array[Dictionary]` on the `step()` result. ✓ `api-gdext/src/lib.rs:4317-4344` projects `result.ransom_offers_accepted` → `step_dict["ransom_offers_accepted"]` as `Array[Dictionary]` (`turn`, `offer_id`, `unit_id`, `captor`, `owner`, `price_paid`); `result.ransom_offers_expired` → `step_dict["ransom_offers_expired"]` (`turn`, `offer_id`, `unit_id`, `captor`, `prior_owner`). `cargo check --workspace` clean on apricot.
- [ ] godot-engine chronicle subscriber reads from these new arrays directly; cross-reference workaround removed.
- [ ] Test in `mc-turn/tests/ransom.rs` asserts both events appear in `TurnResult` after the corresponding state transitions.
- [x] Test in `mc-turn/tests/ransom.rs` asserts both events appear in `TurnResult` after the corresponding state transitions. ✓ 3 new tests at the tail of the file: `pending_capture_events_drain_accept_into_turn_result`, `pending_capture_events_drain_expired_into_turn_result`, `pending_capture_events_is_empty_considers_new_vecs`. `cargo test -p mc-turn --test ransom` — 10/10 pass on apricot.
## Out of scope