applications/magicciv
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(world-map): ♻️ Rename display_name to name_display for consistency in WorldMap and Unit classes

Browse source 
Co-Authored-By: Lilith Autocommit <noreply@atlilith.com>
This commit is contained in:
Claude Code 2026-04-10 09:44:50 -07:00
parent af174c308a
commit fee70d5b0b
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/game/engine/scenes/world_map/world_map.gd
View file

@ -438,8 +438,8 @@ func _check_village_discovery(axial: Vector2i) -> void:
func _show_unit_panel(unit: RefCounted) -> void:
var display_name: String = ThemeVocabulary.lookup(unit.type_id)
if unit.name != "" and unit.name != unit.type_id:
display_name = unit.name
if unit.display_name != "" and unit.display_name != unit.type_id:
display_name = unit.display_name
var stats: String = (
"HP: %d/%d ATK: %d DEF: %d" % [unit.hp, unit.max_hp, unit.attack, unit.defense]
)

13
src/game/engine/src/entities/unit.gd
View file

@ -102,9 +102,16 @@ func _populate_from_data() -> void:
unit_type = data.get("combat_type", "")
if display_name.is_empty():
display_name = data.get("name", unit_id.capitalize())
var keywords: Array = data.get("keywords", [])
can_found_city = "found_city" in keywords or unit_type == "settler"
can_build_improvements = "build" in keywords or unit_type == "worker"
var is_founder: bool = (
unit_id.contains("founder") or unit_id.contains("settler")
)
can_found_city = data.get("can_found_city", is_founder)
var is_builder: bool = (
unit_id.contains("worker") or unit_id.contains("engineer")
)
can_build_improvements = data.get(
"can_build_improvements", is_builder
)
# ── Per-turn refresh (called by turn_processor.gd) ────────────────────