applications/magicciv
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix(@projects/@magic-civilization): 🐛 mark replay_viewer labels unique_name_in_owner

Browse source 
replay_viewer.gd:_ready accesses %TitleLabel, %PlaceholderLabel, %Speed1x,
%Speed2x, but those .tscn nodes lacked unique_name_in_owner (the prior i18n
commit added the %-accesses without flagging the nodes). %TitleLabel/% Placeholder
are read unguarded in _ready → "Node not found" + null .text assignment, which
fires whenever the replay viewer is shown (standalone past-games OR embedded in
the statistics replay tab) — a real runtime bug, not just a test artifact.

Clears test_statistics_modal + removes 9 %TitleLabel / 11 null-text error bleeds
into other tests (GUT global-error entanglement).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Natalie 2026-06-24 04:11:57 -04:00
parent 07d34b6ac9
commit 3652d0fcda
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/game/engine/scenes/menus/replay_viewer.tscn
View file

@ -39,6 +39,7 @@ layout_mode = 2
theme_override_constants/separation = 16
[node name="TitleLabel" type="Label" parent="MarginContainer/VBoxContainer"]
unique_name_in_owner = true
layout_mode = 2
theme_override_font_sizes/font_size = 32
theme_override_colors/font_color = Color(0.9, 0.8, 0.4, 1)
@ -73,6 +74,7 @@ custom_minimum_size = Vector2(0, 300)
color = Color(0.08, 0.08, 0.12, 1)
[node name="PlaceholderLabel" type="Label" parent="MarginContainer/VBoxContainer/WorldMapPlaceholder"]
unique_name_in_owner = true
layout_mode = 1
anchors_preset = 8
anchor_left = 0.5