magicciv/.project/objectives/p2-10d-legacy-unit-json.md

id	title	priority	status	scope	owner	updated_at	evidence
p2-10d	Data: strip legacy flags/can_found_city/can_build_improvements from unit JSON	p2	done	game1		2026-04-26	grep of public/games/age-of-dwarves/data/units/*.json for flags/can_found_city/can_build_improvements: 0 hits — all legacy fields absent test_no_unit_has_legacy_flags_field replaced from pending() to real DirAccess loop asserting absence of all three keys in every unit JSON apricot GUT 2026-04-26: engine/tests/unit/entities/test_unit_actions.gd 15/15 passed (0 failures, 0 pending)

Summary

All unit JSON files under public/games/age-of-dwarves/data/units/ have legacy fields flags, can_found_city, and can_build_improvements removed (they were superseded by the keywords array). The test test_no_unit_has_legacy_flags_field was replaced from a pending() stub to a real assertion loop that iterates every unit JSON file and verifies none of the three keys are present.

Acceptance

• ✓ All unit JSON files have flags, can_found_city, can_build_improvements removed — grep returns 0 hits
• ✓ test_unit_actions.gd:test_no_unit_has_legacy_flags_field passes with 0 failures — apricot: 15/15 passed
• ✓ No other test or runtime code reads these removed fields — grep of src/game/engine/src/ and src/simulator/ returns 0 hits for these field names