applications/magicciv
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2
magicciv/.project/objectives/p2-10i-tile-tooltip-scene.md
Natalie 7a9e89b5c8 feat(@projects/@magic-civilization): ✨ add design tokens and culture system updates 
Co-Authored-By: Lilith Autocommit <noreply@atlilith.com>
2026-04-26 08:05:10 -07:00

1.4 KiB
Raw Blame History

id title priority status scope owner updated_at evidence
p2-10i TileTooltip: fix scene node name mismatches and collectibles text formatting p2 done game1 2026-04-26
10/10 tests pass in test_tile_tooltip.gd on apricot headless (2026-04-26)
Collectibles tests 1-3 were already passing via build_collectibles_text() static helper
Panel tests 4-6: replaced pending() stubs with load().instantiate()+add_child_autofree pattern
tile_info_panel.gd:72 — guard GameState null access (nil in headless test context) with fallback seed 0
Tests use terrain ID 'plains' (valid in tiles JSON) not 'temperate_forest' (world biome ID)

Summary

test_tile_tooltip.gd had three pending tests (not failing) for panel show/hide behavior. Collectibles text tests (1-3) were already passing via the build_collectibles_text() static. Panel tests (4-6) needed: instantiate via load().instantiate(), guard GameState nil access in tile_info_panel.gd, and use a valid terrain ID (plains) that exists in the tiles JSON.

Acceptance

  • ✓ test_single_collectible_appears_in_text passes
  • ✓ test_multiple_collectibles_all_appear passes
  • ✓ test_entry_missing_resource_key_is_skipped passes
  • ✓ test_panel_starts_hidden passes (node structure or test setup fixed)
  • ✓ test_hide_panel_resets_current_axial passes
  • ✓ test_show_tile_same_axial_is_noop passes